Skip to content

Superseded pr17: drag-drop new structure#28

Merged
unkcpz merged 10 commits intomainfrom
pr-17
Dec 13, 2025
Merged

Superseded pr17: drag-drop new structure#28
unkcpz merged 10 commits intomainfrom
pr-17

Conversation

@unkcpz
Copy link
Copy Markdown
Member

@unkcpz unkcpz commented Nov 26, 2025 •
edited
Loading

see #17, I did wrong push and close that PR. Reopen it here with commits form @GeigerJ2

xyz file for test

12
Benzene C6H6
C      0.000000     1.396792     0.000000
C      1.209657     0.698396     0.000000
C      1.209657    -0.698396     0.000000
C      0.000000    -1.396792     0.000000
C     -1.209657    -0.698396     0.000000
C     -1.209657     0.698396     0.000000
H      0.000000     2.490291     0.000000
H      2.156659     1.245145     0.000000
H      2.156659    -1.245145     0.000000
H      0.000000    -2.490291     0.000000
H     -2.156659    -1.245145     0.000000
H     -2.156659     1.245145     0.000000

@unkcpz
Copy link
Copy Markdown
Member Author

unkcpz commented Nov 26, 2025 •
edited
Loading

rebase and almost works.

  • bug0: default structure is there before the default structure button is clicked.
  • bug1: after load the new structure from xyz, the load default only flash to the default structure but flash back to the newly loaded one.
  • bug2: seems there are now two light entities.
  • bug3: a hidden error in the log when click default structure load button when structure is loaded.
  • bug4: when attach light, the angle of light is not kept but from initial value.
  • bug5: the first click on the attach didn't switch the button text.
  • to improve: after feat: light on/off #10 there are buttons on the left up corners, overlap with button and text added is this PR.

I'll fix them in this PR.

@unkcpz unkcpz mentioned this pull request Dec 4, 2025
Closed
@unkcpz unkcpz merged commit 7f8929a into main Dec 13, 2025
3 checks passed
@unkcpz unkcpz deleted the pr-17 branch December 13, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unkcpz @GeigerJ2